linux-kernel - Re: [PATCH v4] rust: Add support for feeding entropy to randomness pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nuK09czKyhZJCy-LLpH5UZ0iB8SBmEMfXDVNu23gybxA@mail.gmail.com>
Date: Wed, 31 Dec 2025 16:46:13 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Matthew Maurer <mmaurer@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, Alexandre Courbot <acourbot@...dia.com>, tytso@....edu
Subject: Re: [PATCH v4] rust: Add support for feeding entropy to randomness pool

On Wed, Dec 31, 2025 at 1:48 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Thanks for CCing me Miguel. I find it strange that it was left out on
> apparently 4 revisions of it. Yes, this should be added to the
> MAINTAINER's normal rng section. I'm happy to maintain this.

You're welcome, and thanks for the quick reply!

> Bigger question, perhaps for Miguel: what's the convention for adding
> these bindings? Is it, (A) "this is a useful API surface, so let's add the
> functions so driver writers can use them later" or is it (B) "add useful
> APIs as they're needed by driver writers"?

We follow the usual kernel practice, so (B), though sometimes a user
is known to be incoming, so it gets added in a separate series for
convenience or similar.

But, yeah, in such a case, it should be agreed upon / explained where
it is supposed to be used, and the cover letter here should do that
(and you are completely right to ask!).

Cheers,
Miguel