linux-kernel - [PATCH v2] ALSA: echoaudio: adjust function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251231161116.141071-1-Julia.Lawall@inria.fr>
Date: Wed, 31 Dec 2025 17:11:16 +0100
From: Julia Lawall <Julia.Lawall@...ia.fr>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: yunbolyu@....edu.sg,
	kexinsun@...il.nju.edu.cn,
	ratnadiraw@....edu.sg,
	xutong.ma@...ia.fr,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] ALSA: echoaudio: adjust function name

The function restore_dsp_rettings sets a lot of things, so change the
name to the more natural restore_dsp_settings.  This name was indeed
already used in a comment above the code in
sound/pci/echoaudio/echoaudio.c.

Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

---
v2: change the function name in the code, rather than in the comment

This was tested by compiling sound/pci/echoaudio/darla20.c, which
includes both files.

 sound/pci/echoaudio/echoaudio.c     |    2 +-
 sound/pci/echoaudio/echoaudio_dsp.c |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index f2c8602a1ad7..8b7b6838106f 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2159,7 +2159,7 @@ static int snd_echo_resume(struct device *dev)
 	 */
 	pipe_alloc_mask = chip->pipe_alloc_mask;
 	chip->pipe_alloc_mask = 0;
-	err = restore_dsp_rettings(chip);
+	err = restore_dsp_settings(chip);
 	chip->pipe_alloc_mask = pipe_alloc_mask;
 	if (err < 0) {
 		kfree(commpage_bak);
diff --git a/sound/pci/echoaudio/echoaudio_dsp.c b/sound/pci/echoaudio/echoaudio_dsp.c
index 2a40091d472c..6e872103305b 100644
--- a/sound/pci/echoaudio/echoaudio_dsp.c
+++ b/sound/pci/echoaudio/echoaudio_dsp.c
@@ -32,7 +32,7 @@
 #error PAGE_SIZE is < 4k
 #endif
 
-static int restore_dsp_rettings(struct echoaudio *chip);
+static int restore_dsp_settings(struct echoaudio *chip);
 
 
 /* Some vector commands involve the DSP reading or writing data to and from the
@@ -666,7 +666,7 @@ static void get_audio_meters(struct echoaudio *chip, long *meters)
 
 
 
-static int restore_dsp_rettings(struct echoaudio *chip)
+static int restore_dsp_settings(struct echoaudio *chip)
 {
 	int i, o, err;
 
@@ -1014,7 +1014,7 @@ static int init_line_levels(struct echoaudio *chip)
 	chip->input_clock = ECHO_CLOCK_INTERNAL;
 	chip->output_clock = ECHO_CLOCK_WORD;
 	chip->sample_rate = 44100;
-	return restore_dsp_rettings(chip);
+	return restore_dsp_settings(chip);
 }