linux-kernel - Re: [PATCH v4 2/2] iio: pressure: add Honeywell ABP2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251231183716.32094776@jic23-huawei>
Date: Wed, 31 Dec 2025 18:37:16 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Petre Rodan <petre.rodan@...dimension.ro>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] iio: pressure: add Honeywell ABP2 driver

On Mon, 29 Dec 2025 17:01:29 +0200
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Sun, Dec 07, 2025 at 08:00:48AM +0200, Petre Rodan wrote:
> > Adds driver for digital Honeywell ABP2 series of board mount
> > pressure and temperature sensors.
> > 
> > This driver covers 113 different pressure ranges and units on
> > both i2c and SPI buses.
> > 
> > The communication protocol involves sending two simple commands
> > to the sensor and there is no register access or a memory map.
> > For this reason the regmap API was not used.
> > 
> > The i2c address is hardcoded and depends on the part number.
> > 
> > Optional end of conversion interrupt control is present on the
> > i2c variants of the chips.
> > The EOC can also be defined for the SPI variants if a non-ABP2
> > but compatible chip is to be driven.
> > 
> > Tested on two sensors (ABP2MRRT001PDSA3 and ABP2DANT001BA2A3).  
> 
> LGTM, one minor thing below,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> 
> ...
> 
> > +		ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> > +				       dev_name(dev), data);
> > +		if (ret)  
> 
> > +			return dev_err_probe(dev, ret, "request irq %d failed\n", data->irq);  
> 
> Just
> 
> 			return ret;
> 
> as above call already prints an error message.
> 
I've had this one queued for a while now, so Petre, if you don't mind
spinning a patch on top to drop that print that would be great.

Jonathan

> > +	}  
>