lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP-5=fWMQ8H8_Y3pNzau8F4pMOZxAXgY=8Rk+YiN2LiYQY+Riw@mail.gmail.com>
Date: Thu, 1 Jan 2026 16:07:07 -0800
From: Ian Rogers <irogers@...gle.com>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: Peter Zijlstra <peterz@...radead.org>, yunbolyu@....edu.sg, kexinsun@...il.nju.edu.cn, 
	ratnadiraw@....edu.sg, xutong.ma@...ia.fr, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/perf/util/addr_location.c: update outdated comment

On Tue, Dec 30, 2025 at 8:52 AM Julia Lawall <Julia.Lawall@...ia.fr> wrote:
>
> The function addr_location__put() was renamed addr_location__exit()
> in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
> functions").  Make the comment preceding the function consistent with
> the function itself.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/addr_location.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/addr_location.c b/tools/perf/util/addr_location.c
> index 007a2f5df9a6..81a0b79c5e10 100644
> --- a/tools/perf/util/addr_location.c
> +++ b/tools/perf/util/addr_location.c
> @@ -24,7 +24,7 @@ void addr_location__init(struct addr_location *al)
>   * The preprocess_sample method will return with reference counts for the
>   * in it, when done using (and perhaps getting ref counts if needing to
>   * keep a pointer to one of those entries) it must be paired with
> - * addr_location__put(), so that the refcounts can be decremented.
> + * addr_location__exit(), so that the refcounts can be decremented.
>   */
>  void addr_location__exit(struct addr_location *al)
>  {
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ