linux-kernel - Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb98e395-d590-47f7-8dba-d9a691a2c174@kernel.org>
Date: Fri, 2 Jan 2026 11:02:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexandru Chimac <alex@...mac.ro>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, Linus Walleij <linusw@...nel.org>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Tomasz Figa <tomasz.figa@...il.com>, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add
 exynos9610-wakeup-eint node

On 31/12/2025 13:28, Alexandru Chimac wrote:
> On Tuesday, December 30th, 2025 at 11:51, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>>
>> On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
>>
>>> Add a dedicated compatible for the exynos9610-wakeup-eint node,
>>> which is compatbile with Exynos850's implementation (and the
>>> Exynos7 fallback).
>>>
>>> Signed-off-by: Alexandru Chimac alex@...mac.ro
>>> ---
>>> .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> index f3c433015b12..deb2730855bd 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> @@ -48,6 +48,7 @@ properties:
>>> - enum:
>>> - google,gs101-wakeup-eint
>>> - samsung,exynos2200-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>> - samsung,exynos9810-wakeup-eint
>>> - samsung,exynos990-wakeup-eint
>>> - samsung,exynosautov9-wakeup-eint
>>> @@ -107,6 +108,7 @@ allOf:
>>> contains:
>>> enum:
>>> - samsung,exynos850-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>
>>
>> This is not needed. Device has 850 fallback, no?
> It's not required, but I guess it would make the device tree look better. If this patch isn't to be merged, it doesn't functionally affect anything so it can just be dropped instead of requiring another patchset revision.

Please wrap your replies.

I did not comment on the patch. Comments are in specific places
discussing specific lines. I asked why do you need this enum to grow?


Best regards,
Krzysztof