linux-kernel - Re: [PATCH v2 1/8] dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260102-maroon-dragon-of-expertise-7bb714@quoll>
Date: Fri, 2 Jan 2026 11:15:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Palmer <daniel@...f.com>
Cc: krzk+dt@...nel.org, romain.perier@...il.com, robh@...nel.org, 
	conor+dt@...nel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/8] dt-bindings: clk: mstar msc313 cpupll: Correct
 clock-cells value

On Thu, Jan 01, 2026 at 12:42:59PM +0900, Daniel Palmer wrote:
> clock-cells should have been 0 and causes warnings when

Why it should have been 0? That's what your commit msg should explain.


> validating devicetrees.
> 
> Fix the value and fix the binding example.
> 
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> ---
>  .../devicetree/bindings/clock/mstar,msc313-cpupll.yaml       | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml b/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> index a9ad7ab5230c..889419fba269 100644
> --- a/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> +++ b/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> @@ -18,7 +18,7 @@ properties:
>      const: mstar,msc313-cpupll
>  
>    "#clock-cells":
> -    const: 1
> +    const: 0

That's technically ABI break and your commit msg must explain also the
impact of that break.

Best regards,
Krzysztof