linux-kernel - Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <baa3ff2a-6569-4b36-aed1-651f83fa175b@kernel.org>
Date: Fri, 2 Jan 2026 11:18:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Akhila YS <akhilayalmati@...il.com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-mtd@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT
 schema

On 02/01/2026 09:17, Akhila YS wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - microchip,mchp23k256
>>> +      - microchip,mchp23lcv1024
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 1
>> Pretty incomplete. Old binding and above cells claim there can be child
>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>> either old binding was incorrect or new binding is incomplete. I did not
>> check the driver, though.
> 
> 
> Size cells and Address cells are not required as there is no child node

Then what is the point of address/size cells if you do not have children?

Anyway, read carefully old binding and the driver code.

Best regards,
Krzysztof