linux-kernel - Re: [PATCH 1/2] dt-bindings: pinctrl: Add Mahua TLMM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e25da82-6a26-4ade-9247-1bb7abd5615c@kernel.org>
Date: Fri, 2 Jan 2026 12:10:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gopikrishna Garmidi <gopikrishna.garmidi@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>, Linus Walleij <linusw@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Rajendra Nayak <rajendra.nayak@....qualcomm.com>,
 Pankaj Patil <pankaj.patil@....qualcomm.com>,
 Sibi Sankar <sibi.sankar@....qualcomm.com>
Cc: Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add Mahua TLMM support

On 02/01/2026 12:07, Gopikrishna Garmidi wrote:
> Update the compatible property to accept both "qcom,glymur-tlmm" and
> "qcom,mahua-tlmm" using enum to allow proper device tree validation
> for both SoCs.

1. Why? You explained what, with a lot of redundant words. I do not find
"paid by commit line" useful. Drop all the redundancies, do not explain
what is "device tree validation". Look at other commits to learn how
this is supposed to be written.

2. Why they are not compatible? You have entire commit msg to say
something useful instead stating obvious and repeating the diff.

3. Subject: You cannot add "support" in the binding. Again, look at
other commits.

Best regards,
Krzysztof