linux-kernel - Re: [PATCH V2 2/4] scsi: ufs: qcom: dt-bindings: Document UFSHC compatible for x1e80100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260102-rapid-abiding-parakeet-d0735f@quoll>
Date: Fri, 2 Jan 2026 12:25:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pradeep P V K <pradeep.pragallapati@....qualcomm.com>
Cc: vkoul@...nel.org, neil.armstrong@...aro.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, martin.petersen@...cle.com, 
	andersson@...nel.org, konradybcio@...nel.org, taniya.das@....qualcomm.com, 
	dmitry.baryshkov@....qualcomm.com, manivannan.sadhasivam@....qualcomm.com, 
	linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, nitin.rawat@....qualcomm.com
Subject: Re: [PATCH V2 2/4] scsi: ufs: qcom: dt-bindings: Document UFSHC
 compatible for x1e80100

On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote:
> Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100
> SoC.  Use SM8550 as a fallback since x1e80100 shares compatibility
> with SM8550 UFSHC, enabling reuse of existing support.

Your last sentence is redundant. "Make devices compatible because they
are compatible". Why are they compatible? Or just say that you add a new
device fully compatible with SM8550. Write concise and informative
statements, not long elaborted paragraphs where only few words are the
actual information

> 
> Signed-off-by: Pradeep P V K <pradeep.pragallapati@....qualcomm.com>
> ---
>  .../bindings/ufs/qcom,sc7180-ufshc.yaml       | 38 +++++++++++--------
>  1 file changed, 23 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> index d94ef4e6b85a..0f6ea7ca06c8 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> @@ -26,26 +26,34 @@ select:
>            - qcom,sm8350-ufshc
>            - qcom,sm8450-ufshc
>            - qcom,sm8550-ufshc
> +          - qcom,x1e80100-ufshc

You don't need this.

>    required:
>      - compatible

Best regards,
Krzysztof