linux-kernel - Re: [PATCH 1/6] dt-bindings: serial: google,goldfish-tty: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260102-fast-clay-jackrabbit-6d6637@quoll>
Date: Fri, 2 Jan 2026 13:18:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, dmitry.torokhov@...il.com, sre@...nel.org, 
	gregkh@...uxfoundation.org, jirislaby@...nel.org, lgirdwood@...il.com, broonie@...nel.org, 
	jserv@...s.ncku.edu.tw, eleanor15x@...il.com, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-serial@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: serial: google,goldfish-tty: Convert to
 DT schema

On Tue, Dec 30, 2025 at 06:10:26PM +0000, Kuan-Wei Chiu wrote:
> Convert the Google Goldfish TTY binding to DT schema format.
> Move the file to the serial directory to match the subsystem.
> Update the example node name to 'serial' to comply with generic node
> naming standards.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
> ---
>  .../devicetree/bindings/goldfish/tty.txt      | 17 ---------
>  .../bindings/serial/google,goldfish-tty.yaml  | 38 +++++++++++++++++++
>  2 files changed, 38 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/goldfish/tty.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> 
> diff --git a/Documentation/devicetree/bindings/goldfish/tty.txt b/Documentation/devicetree/bindings/goldfish/tty.txt
> deleted file mode 100644
> index 82648278da77..000000000000
> --- a/Documentation/devicetree/bindings/goldfish/tty.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Android Goldfish TTY
> -
> -Android goldfish tty device generated by android emulator.
> -
> -Required properties:
> -
> -- compatible : should contain "google,goldfish-tty" to match emulator
> -- reg        : <registers mapping>
> -- interrupts : <interrupt mapping>
> -
> -Example:
> -
> -	goldfish_tty@...04000 {
> -		compatible = "google,goldfish-tty";
> -		reg = <0x1f004000 0x1000>;
> -		interrupts = <0xc>;
> -	};
> diff --git a/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> new file mode 100644
> index 000000000000..08fa12449a01
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/google,goldfish-tty.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google Goldfish TTY
> +
> +maintainers:
> +  - Kuan-Wei Chiu <visitorckw@...il.com>
> +

Missing allOf to /schemas/serial/serial, unless this is not a serial, but then your
commit msg should explain that.

Best regards,
Krzysztof