[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e3c6cd7b-0a18-4016-8131-cd14d1b32300@arm.com>
Date: Fri, 2 Jan 2026 14:40:04 +0000
From: Ben Horgan <ben.horgan@....com>
To: Mark Brown <broonie@...nel.org>, Marc Zyngier <maz@...nel.org>,
Joey Gouly <joey.gouly@....com>, Suzuki K Poulose <suzuki.poulose@....com>,
Paolo Bonzini <pbonzini@...hat.com>, Shuah Khan <shuah@...nel.org>,
Oliver Upton <oupton@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] KVM: selftests: arm64: Report set_id_reg reads of
test registers as tests
Hi Mark,
On 12/19/25 19:28, Mark Brown wrote:
> Currently when we run guest code to validate that the values we wrote to
> the registers are seen by the guest we assert that these values match using
> a KVM selftests level assert, resulting in unclear diagnostics if the test
> fails. Replace this assert with reporting a kselftest test per register.
>
> In order to support getting the names of the registers we repaint the array
> of ID_ registers to store the names and open code the rest.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
> tools/testing/selftests/kvm/arm64/set_id_regs.c | 74 +++++++++++++++++++------
> 1 file changed, 57 insertions(+), 17 deletions(-)
>
Looks like an improvement to me.
Reviewed-by: Ben Horgan <ben.horgan@....com>
Thanks,
Ben
Powered by blists - more mailing lists