lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc7x5xq2ufanc5vesvs6ccvulfiddqjcf74r7pp3tr4bfiomib@akskveejglww>
Date: Fri, 2 Jan 2026 07:14:05 -0800
From: Breno Leitao <leitao@...ian.org>
To: Usama Arif <usamaarif642@...il.com>
Cc: Alexander Graf <graf@...zon.com>, Mike Rapoport <rppt@...nel.org>, 
	Pasha Tatashin <pasha.tatashin@...een.com>, Pratyush Yadav <pratyush@...nel.org>, 
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, linux-mm@...ck.org, rmikey@...a.com, 
	clm@...com, riel@...riel.com, kernel-team@...a.com
Subject: Re: [PATCH v2 1/2] kexec: history: track previous kernel version

Hello Usama,

On Fri, Jan 02, 2026 at 06:02:39PM +0300, Usama Arif wrote:
> On 02/01/2026 17:53, Breno Leitao wrote:
> I think we should make this default if KHO is enabled, i.e. not have a Kconfig
> option for this. The cost of storing the char array is negligable.

Sure, I can get it enabled by default once KHO gets enabled. Thanks for
the feedback.

> > +	pr_info("This kernel was kexec'ed from kernel release: %s\n",
> > +		kho_in.previous_release);
> 
> Maybe s/release/version everywhere? It might not be a release, but no strong opinion.

As I understand, in the kernel parlance, "version" is something
different from "release", and what we want here is "release". Here is an
example of uname, which also matches with kernel source code and UTS.

  # uname --kernel-version
  #1 SMP Mon Nov 17 07:00:42 PST 2025

  # uname --kernel-release
  6.16.1-0_gc0739ee5037a

Thanks for the review,
--breno

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ