linux-kernel - Re: [PATCH] clk: tegra: tegra124-emc: Simplify with scoped for each OF child loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf03ca52-41fb-405f-8455-5fb128289f5f@nvidia.com>
Date: Fri, 2 Jan 2026 16:08:43 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
 Peter De Schrijver <pdeschrijver@...dia.com>,
 Prashant Gaikwad <pgaikwad@...dia.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Thierry Reding <thierry.reding@...il.com>,
 linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: tegra: tegra124-emc: Simplify with scoped for each
 OF child loop


On 02/01/2026 12:50, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> ---
>   drivers/clk/tegra/clk-tegra124-emc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c
> index 2a6db0434281..2953b62cb619 100644
> --- a/drivers/clk/tegra/clk-tegra124-emc.c
> +++ b/drivers/clk/tegra/clk-tegra124-emc.c
> @@ -444,7 +444,6 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
>   				u32 ram_code)
>   {
>   	struct emc_timing *timings_ptr;
> -	struct device_node *child;
>   	int child_count = of_get_child_count(node);
>   	int i = 0, err;
>   	size_t size;
> @@ -458,12 +457,11 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
>   	timings_ptr = tegra->timings + tegra->num_timings;
>   	tegra->num_timings += child_count;
>   
> -	for_each_child_of_node(node, child) {
> +	for_each_child_of_node_scoped(node, child) {
>   		struct emc_timing *timing = timings_ptr + (i++);
>   
>   		err = load_one_timing_from_dt(tegra, timing, child);
>   		if (err) {
> -			of_node_put(child);
>   			kfree(tegra->timings);
>   			return err;
>   		}


Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks!
Jon

-- 
nvpublic