linux-kernel - Re: [PATCH v5 1/3] KVM: x86: Refactor suppress EOI broadcast logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e09b6b6f623e98a2b21a1da83ff8071a0a87f021.camel@infradead.org>
Date: Fri, 02 Jan 2026 16:23:35 +0000
From: David Woodhouse <dwmw2@...radead.org>
To: Khushit Shah <khushit.shah@...anix.com>, seanjc@...gle.com, 
	pbonzini@...hat.com, kai.huang@...el.com
Cc: mingo@...hat.com, x86@...nel.org, bp@...en8.de, hpa@...or.com, 
 linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 dave.hansen@...ux.intel.com,  tglx@...utronix.de, jon@...anix.com,
 shaju.abraham@...anix.com
Subject: Re: [PATCH v5 1/3] KVM: x86: Refactor suppress EOI broadcast logic

On Mon, 2025-12-29 at 11:17 +0000, Khushit Shah wrote:
> Extract the suppress EOI broadcast (Directed EOI) logic into helper
> functions and move the check from kvm_ioapic_update_eoi_one() to
> kvm_ioapic_update_eoi() (required for a later patch). Prepare
> kvm_ioapic_send_eoi() to honor Suppress EOI Broadcast in split IRQCHIP
> mode.
> 
> Introduce two helper functions:
> - kvm_lapic_advertise_suppress_eoi_broadcast(): determines whether KVM
>   should advertise Suppress EOI Broadcast support to the guest
> - kvm_lapic_respect_suppress_eoi_broadcast(): determines whether KVM should
>   honor the guest's request to suppress EOI broadcasts
> 
> This refactoring prepares for I/O APIC version 0x20 support and userspace
> control of suppress EOI broadcast behavior.
> 
> Signed-off-by: Khushit Shah <khushit.shah@...anix.com>

Looks good to me, thanks for pushing this through to completion!


Reviewed-by: David Woodhouse <dwmw@...zon.co.uk>

Nit: Ideally I would would prefer to see an explicit 'no functional
change intended' and a reference to commit 0bcc3fb95b97a.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5069 bytes)