linux-kernel - Re: [PATCH 1/6] video/logo: remove orphan .pgm Makefile rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e04c9862-761f-4f36-b978-b760d2a0a928@ixit.cz>
Date: Fri, 2 Jan 2026 17:34:12 +0100
From: David Heidelberg <david@...t.cz>
To: Vincent Mailhol <mailhol@...nel.org>, Helge Deller <deller@....de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>,
 John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/6] video/logo: remove orphan .pgm Makefile rule

On 30/12/2025 23:20, Vincent Mailhol wrote:
> The kernel has no actual grey-scale logos. And looking at the git
> history, it seems that there never was one (or maybe there was in the
> pre-git history? I did not check that far…)
> 
> Remove the Makefile rule for the .pgm grey scale images.

Great to see this series.

I think the Fixes: tag should still go here, even if it is not very 
specific.

David

> 
> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>
> ---
>   drivers/video/logo/Makefile | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 895c60b8402e..8b67c4941a4c 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -30,8 +30,5 @@ $(obj)/%.c: $(src)/%.pbm $(obj)/pnmtologo FORCE
>   $(obj)/%.c: $(src)/%.ppm $(obj)/pnmtologo FORCE
>   	$(call if_changed,logo)
>   
> -$(obj)/%.c: $(src)/%.pgm $(obj)/pnmtologo FORCE
> -	$(call if_changed,logo)
> -
>   # generated C files
> -targets += *_mono.c *_vga16.c *_clut224.c *_gray256.c
> +targets += *_mono.c *_vga16.c *_clut224.c
> 

-- 
David Heidelberg