linux-kernel - Re: [PATCH] tpm: st33zp24: Fix missing cleanup on get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVgAX5C5ih1VsNAD@kernel.org>
Date: Fri, 2 Jan 2026 19:29:03 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Alper Ak <alperyasinak1@...il.com>
Cc: peterhuewe@....de, Jason Gunthorpe <jgg@...pe.ca>,
	Stefano Garzarella <sgarzare@...hat.com>,
	Christophe Ricard <christophe.ricard@...il.com>,
	linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount()
 error

On Fri, Dec 26, 2025 at 03:09:27PM +0300, Alper Ak wrote:
> get_burstcount() can return -EBUSY on timeout. When this happens,
> st33zp24_send() returns directly without releasing the locality
> acquired earlier.
> 
> Use goto out_err to ensure proper cleanup when get_burstcount() fails.
> 
> Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
> Signed-off-by: Alper Ak <alperyasinak1@...il.com>
> ---
>  drivers/char/tpm/st33zp24/st33zp24.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
> index 2ed7815e4899..e2b7451ea7cc 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -328,8 +328,10 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
>  
>  	for (i = 0; i < len - 1;) {
>  		burstcnt = get_burstcount(chip);
> -		if (burstcnt < 0)
> -			return burstcnt;
> +		if (burstcnt < 0) {
> +			ret = burstcnt;
> +			goto out_err;
> +		}
>  		size = min_t(int, len - i - 1, burstcnt);
>  		ret = tpm_dev->ops->send(tpm_dev->phy_id, TPM_DATA_FIFO,
>  					 buf + i, size);
> -- 
> 2.43.0
> 

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko