linux-kernel - Re: [PATCH] dmaengine: tegra210-adma: use platform to ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87277d5f-428c-432d-9de7-e000c2c1cab9@nvidia.com>
Date: Fri, 2 Jan 2026 18:14:35 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Rosen Penev <rosenp@...il.com>, dmaengine@...r.kernel.org
Cc: Laxman Dewangan <ldewangan@...dia.com>, Vinod Koul <vkoul@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>,
 "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: tegra210-adma: use platform to ioremap


On 23/12/2025 20:46, Rosen Penev wrote:
> Simpler to call the proper function.

We are using a 'proper' function. I think that what you are trying to 
saying that we can simplify the code by just using 
devm_platform_ioremap_resource(). Change looks fine, but the commit 
message and subject could be improved.

Jon

> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>   drivers/dma/tegra210-adma.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index 215bfef37ec6..5353fbb3d995 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -1073,14 +1073,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
>   		}
>   	} else {
>   		/* If no 'page' property found, then reg DT binding would be legacy */
> -		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		if (res_base) {
> -			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
> -			if (IS_ERR(tdma->base_addr))
> -				return PTR_ERR(tdma->base_addr);
> -		} else {
> -			return -ENODEV;
> -		}
> +		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
> +		if (IS_ERR(tdma->base_addr))
> +			return PTR_ERR(tdma->base_addr);
>   
>   		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
>   	}

-- 
nvpublic