linux-kernel - Re: [PATCH 1/2] dt-bindings: interrupt-controller: qcom,pdc: Document x1p42100 PDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yulnacbkob2bxmqzkivbawshofi2byxjbqzel2edkvqko2rtfg@zzxzdsvgbzjb>
Date: Fri, 2 Jan 2026 12:35:30 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Maulik Shah <maulik.shah@....qualcomm.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: qcom,pdc:
 Document x1p42100 PDC

On Wed, Dec 31, 2025 at 11:49:00AM +0100, Krzysztof Kozlowski wrote:
> On 31/12/2025 11:18, Maulik Shah wrote:
> > Purwa shares the Hamoa (X1E80100) PDC device, but the hardware register
> 
> We don't use Hamoa name in upstream.
> 

Using "Hamoa" and "Purwa" is approved and IMO preferable. I do like how
Maulik included the X1E80100 name here, to ensure continuity with times
before we did.

In fact, I'd prefer $subject to use "Purwa" instead of "x1p42100" -
quite likely that's not even the Purwa SKU that Maulik tested this on.

Regards,
Bjorn

> > bug addressed in commit e9a48ea4d90b ("irqchip/qcom-pdc: Workaround
> > hardware register bug on X1E80100") is already fixed in Purwa silicon.
> > 
> > Hamoa compatible forces the software workaround. Add PDC compatible
> > for purwa as "qcom,x1p42100-pdc" to remove the workaround from Purwa.
> > 
> > Fixes: f08edb529916 ("arm64: dts: qcom: Add X1P42100 SoC and CRD")
> 
> Your are describing wrong bug being fixed... or actually not a bug.
> Every SoC should have dedicated compatible (see writing bindings) and
> missing compatible is not a bug.
> 
> Best regards,
> Krzysztof