linux-kernel - Re: [PATCH v2] docs: find-unused-docs.sh: fixup directory usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVgm5D4EvDkS4TMk@casper.infradead.org>
Date: Fri, 2 Jan 2026 20:13:24 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v2] docs: find-unused-docs.sh: fixup directory usage

On Fri, Jan 02, 2026 at 12:06:57PM -0800, Randy Dunlap wrote:
> The recent move of this script from scripts/ to tools/docs/
> did not account for the 'cd' directory usage.
> Update "cd .." to "cd ../.." to make the script self-correcting.
> 
> This also eliminates a shell warning:
> ./tools/docs/find-unused-docs.sh: line 33: cd: Documentation/: No such file or directory
> 
> Fixes: 184414c6a6ca ("docs: move find-unused-docs.sh to tools/docs")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Hah.  I just committed this same patch.

    docs: Fix find-unused-docs.sh

    find-unused-docs.sh cares about which directory it lives in.
    After being moved from scripts/ to tools/docs/, it emits:

    ./tools/docs/find-unused-docs.sh: line 33: cd: Documentation/: No such file or directory

    and then claims that all files are omitted from the formatted
    documentation.  I opted for the simple fix here rather than trying to
    remove that dependency.

    Fixes: 184414c6a6ca (docs: move find-unused-docs.sh to tools/docs)
    Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>

You posted it first, so:

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

(feel free to use any parts of my commit message if you prefer them to
yours)

> v2: correct subject line typos (2) (arg, kbd error!)
> 
> Cc: Jonathan Corbet <corbet@....net>
> Cc: linux-doc@...r.kernel.org
> 
>  tools/docs/find-unused-docs.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20251219.orig/tools/docs/find-unused-docs.sh
> +++ linux-next-20251219/tools/docs/find-unused-docs.sh
> @@ -28,7 +28,7 @@ if ! [ -d "$1" ]; then
>  fi
>  
>  cd "$( dirname "${BASH_SOURCE[0]}" )"
> -cd ..
> +cd ../..
>  
>  cd Documentation/
>  
>