linux-kernel - Re: [PATCH v7 2/2] media: i2c: add os05b10 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVg3S5xnTpXCBUyf@kekkonen.localdomain>
Date: Fri, 2 Jan 2026 23:23:23 +0200
From: "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
To: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
Cc: Tarang Raval <tarang.raval@...iconsignals.io>,
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
	"robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>,
	Mehdi Djait <mehdi.djait@...ux.intel.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Hans Verkuil <hverkuil@...nel.org>,
	Hans de Goede <hansg@...nel.org>,
	André Apitzsch <git@...tzsch.eu>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Dongcheng Yan <dongcheng.yan@...el.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
	Jingjing Xiong <jingjing.xiong@...el.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 2/2] media: i2c: add os05b10 image sensor driver

Hi Himanshu,

On Fri, Jan 02, 2026 at 06:10:09AM +0000, Himanshu Bhavani wrote:
> Hi Sakari,
> >
> >On Thu, Jan 01, 2026 at 06:19:02AM +0000, Himanshu Bhavani wrote:
> >> >> +#define OS05B10_PIXEL_RATE           (480 * HZ_PER_MHZ)
> >> >
> >> >Here pixel rate should not be hardcoded, it'd be computed in runtime
> >> >as 600MHz * 2 * 4 lanes / 10 bpp = 480MHz.
> >> >
> >> >The sensor may be wired over 2 lanes or (presumably) it can stream 8 bpp data.
> >>
> >> We are not supporting 2 lanes right now, driver supports only for 4 lanes and
> >> 10 bpp data. So technically OS05B10_PIXEL_RATE will never change.
> >> For reference I will add OS05B10_PIXEL_RATE calculation in comments.
> >> I would prefer the hardcoded at the moment. Other than this comment
> >> I will resolve and send new version.
> >
> >The pixel rate on the pixel array may be disconnected from the link
> >frequency (and throughput) -- it may be more (with e.g. binning) or less,
> >depending on the sensor of course. Calculating it, if possible, is always
> >better than using a fixed value; experience has shown these are often
> >simply incorrect and sometimes not updated when other changes are made (and
> >same goes for the link frequency).
> 
> Okay, I just want to know if this is non-blocking comment and we can go ahead
> with current version of driver.
> 
> Meanwhile my colleague Tarang is working on some features and he is planning
> to send a series on top of this driver. If he takes up this comment in that
> series will it be okay with you?

Isn't calculating the frequency a fairly trivial thing to do? Why not to do
it now?

> 
> And also I have already sent next revision v8.
> Please let me know.
> 

-- 
Regards,

Sakari Ailus