linux-kernel - Re: [PATCH] fs/afs: Remove unnecessary integer promotion in format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260102224006.39c8398e@pumpkin>
Date: Fri, 2 Jan 2026 22:40:06 +0000
From: David Laight <david.laight.linux@...il.com>
To: Dipendra Khadka <kdipendra88@...il.com>
Cc: dhowells@...hat.com, marc.dionne@...istor.com,
 linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/afs: Remove unnecessary integer promotion in format
 strings

On Fri,  2 Jan 2026 11:57:40 +0000
Dipendra Khadka <kdipendra88@...il.com> wrote:

> Remove 'h' length modifier from printk format strings where integer
> promotion makes it redundant. When short integers are passed to
> variadic functions like pr_notice(), they are automatically promoted
> to int, making the 'h' modifier unnecessary.

Fairly pointless churn for existing code.

The message isn't really right either, 'short integers' are always
promoted to 'int' whenever they are used.
There is nothing special about variadic functions.

	David