linux-kernel - Re: [PATCH] drm/amdgpu: update outdated comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <668b84cf-2435-4695-a192-c6c2b89737a6@amd.com>
Date: Fri, 2 Jan 2026 17:46:52 -0500
From: "Kuehling, Felix" <felix.kuehling@....com>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: yunbolyu@....edu.sg, kexinsun@...il.nju.edu.cn, ratnadiraw@....edu.sg,
 xutong.ma@...ia.fr, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: update outdated comment

On 2025-12-30 12:53, Julia Lawall wrote:
> The function amdgpu_amdkfd_gpuvm_import_dmabuf() was split into
> import_obj_create() and amdgpu_amdkfd_gpuvm_import_dmabuf_fd() in
> commit 0188006d7c79 ("drm/amdkfd: Import DMABufs for interop
> through DRM").  import_obj_create() now does the allocation for
> the mem variable discussed in the comment.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Reviewed-by: Felix Kuehling <felix.kuehling@....com>

for this and your other amdkfd patch. I submitted them to 
amd-staging-drm-next.

Thanks,
   Felix


>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index b1c24c8fa686..4782265d5e91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1987,7 +1987,8 @@ int amdgpu_amdkfd_gpuvm_free_memory_of_gpu(
>   	drm_gem_object_put(&mem->bo->tbo.base);
>   
>   	/*
> -	 * For kgd_mem allocated in amdgpu_amdkfd_gpuvm_import_dmabuf(),
> +	 * For kgd_mem allocated in import_obj_create() via
> +	 * amdgpu_amdkfd_gpuvm_import_dmabuf_fd(),
>   	 * explicitly free it here.
>   	 */
>   	if (!use_release_notifier)
>