linux-kernel - Re: [PATCH v9 01/11] PCI/P2PDMA: Separate the mmap() support from the core logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260102234033.GA246107@bhelgaas>
Date: Fri, 2 Jan 2026 17:40:33 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Alex Williamson <alex@...zbot.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 01/11] PCI/P2PDMA: Separate the mmap() support from
 the core logic

[cc list trimmed]

On Thu, Nov 20, 2025 at 11:28:20AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> Currently the P2PDMA code requires a pgmap and a struct page to
> function. The was serving three important purposes:
> ...

> +++ b/include/linux/pci-p2pdma.h
> @@ -16,6 +16,16 @@
>  struct block_device;
>  struct scatterlist;
>  
> +/**
> + * struct p2pdma_provider
> + *
> + * A p2pdma provider is a range of MMIO address space available to the CPU.
> + */

Already upstream (f58ef9d1d135 ("PCI/P2PDMA: Separate the mmap()
support from the core logic")), but this adds kerneldoc warnings:

  Warning: include/linux/pci-p2pdma.h:26 struct member 'owner' not described in 'p2pdma_provider'
  Warning: include/linux/pci-p2pdma.h:26 struct member 'bus_offset' not described in 'p2pdma_provider'

Repro:

  $ scripts/kernel-doc -none include/linux/pci-p2pdma.h

> +struct p2pdma_provider {
> +	struct device *owner;
> +	u64 bus_offset;
> +};