linux-kernel - [BUG] pinctrl: mt7981: some obviously incorrect register maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <OS7PR01MB13834E7D3E265DAFD58CEFF92BCB8A@OS7PR01MB13834.jpnprd01.prod.outlook.com>
Date: Sat,  3 Jan 2026 17:28:16 +0800
From: Shiji Yang <yangshiji66@...look.com>
To: linux-mediatek@...ts.infradead.org
Cc: Sean Wang <sean.wang@...nel.org>,
	Linus Walleij <linusw@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Ryder Lee <ryder.lee@...iatek.com>,
	Weijie Gao <weijie.gao@...iatek.com>,
	Chunfeng Yun <chunfeng.yun@...iatek.com>,
	GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@...iatek.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Shiji Yang <yangshiji66@...look.com>
Subject: [BUG] pinctrl: mt7981: some obviously incorrect register maps

Hi,
In 'drivers/pinctrl/mediatek/pinctrl-mt7981.c', I noticed that some
register map definitions are clearly incorrect because the same bits
are used to control different pin functions. I think these are obvious
copy && paste issues. Perhaps there are more wrong PIN_FIELD_BASE
definitions than what I've found here. If you have relevant programming
guide documents, please help check and fix them.

```
static const struct mtk_pin_field_calc mt7981_pin_ies_range[] = {
	PIN_FIELD_BASE(11, 11, 5, 0x40, 0x10, 10, 1), // regmap overlap
};

static const struct mtk_pin_field_calc mt7981_pin_smt_range[] = {
	PIN_FIELD_BASE(44, 44, 7, 0x30, 0x10, 8, 1), // regmap overlap
};

static const struct mtk_pin_field_calc mt7981_pin_drv_range[] = {
	PIN_FIELD_BASE(3, 3, 4, 0x00, 0x10, 18, 1), // ? need check
	PIN_FIELD_BASE(11, 11, 5, 0x00, 0x10, 0, 3), // regmap overlap
	PIN_FIELD_BASE(13, 13, 5, 0x00, 0x10, 3, 3), // regmap overlap
	PIN_FIELD_BASE(15, 15, 2, 0x00, 0x10, 0, 3), // regmap overlap
	PIN_FIELD_BASE(34, 34, 4, 0x00, 0x10, 15, 3), // ? need check
};

static const struct mtk_pin_field_calc mt7981_pin_pupd_range[] = {
	PIN_FIELD_BASE(20, 20, 2, 0x90, 0x10, 3, 1), // regmap overlap
};
```

Regards,
Shiji Yang