linux-kernel - Re: [PATCH v1] i2c: rk3x: Add support for SCL output enable debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1802774.yIU609i1g2@diego>
Date: Sat, 03 Jan 2026 11:39:40 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Andi Shyti <andi.shyti@...nel.org>,
 "moderated list:ARM/Rockchip SoC support"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:ARM/Rockchip SoC support" <linux-rockchip@...ts.infradead.org>,
 "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>
Cc: Anand Moon <linux.amoon@...il.com>, David Wu <david.wu@...k-chips.com>
Subject: Re: [PATCH v1] i2c: rk3x: Add support for SCL output enable debounce

Am Samstag, 3. Januar 2026, 06:25:04 Mitteleuropäische Normalzeit schrieb Anand Moon:
> From: David Wu <david.wu@...k-chips.com>
> 
> As per the RK3399 and RK3588 datasheets Rockchip I2C controllers feature
> a SCL_OE_DB register (0x24). This register is used to configure the
> debounce time for the SCL output enable signal, which helps prevent
> glitches and ensures timing compliance during bus handover or slave clock
> stretching.
> 
> Introduce a 'has_scl_oe_debounce' flag to rk3x_i2c_soc_data to
> distinguish between hardware versions. For supported SoCs, calculate
> the debounce counter dynamically based on the current clock rate
> and program it during divider adaptation.
> 
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> Signed-off-by: David Wu <david.wu@...k-chips.com>

Signed-off-by lines are in the wrong order.

Original author first, then yours as you're the one handling
the patch last.


Also, does this fix a problem for you, or is this more a case of
"this looks useful"?

Thanks
Heiko