linux-kernel - Re: [PATCH v2] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260103123910.169563-1-zilin@seu.edu.cn>
Date: Sat,  3 Jan 2026 12:39:10 +0000
From: Zilin Guan <zilin@....edu.cn>
To: markus.elfring@....de
Cc: James.Bottomley@...senPartnership.com,
	don.brace@...rochip.com,
	jianhao.xu@....edu.cn,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	martin.petersen@...cle.com,
	storagedev@...rochip.com,
	zilin@....edu.cn
Subject: Re: [PATCH v2] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft_reset()

On Wed, Dec 31, 2025 at 05:25:23PM +0100, Markus Elfring wrote:
> …
> > +++ b/drivers/scsi/hpsa.c
> > @@ -8212,6 +8212,7 @@ static void hpsa_undo_allocations_after_kdump_soft_reset(struct ctlr_info *h)
> >  		h->monitor_ctlr_wq = NULL;
> >  	}
> >  
> > +	kfree(h->reply_map);		/* init_one 1 */
> >  	kfree(h);				/* init_one 1 */
> >  }
> 
> I wonder about the alignment and relevance for these code comments.
> 
> Regards,
> Markus

Hi Markus,

Thank you for your review.

Regarding the alignment, it was an oversight caused by the inconsistency 
between my editor configuration and the Linux kernel's style. I will 
correct this in v3.

As for the code comment, it indicates that the memory being freed here 
was allocated during the first stage of initialization in 
hpsa_init_one(). I included it to maintain consistency with the existing 
kfree(h) line immediately following it.

Best regards,
Zilin Guan