linux-kernel - Re: [PATCH v1 3/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <spnzzacpelmkzccithxwnhr2e6fncuqrd46ybhplnryl2fnswy@pblwhdupnxws>
Date: Sat, 3 Jan 2026 09:08:58 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Gaurav Kohli <gaurav.kohli@....qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
	mathieu.poirier@...aro.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	rafael@...nel.org, daniel.lezcano@...aro.org, rui.zhang@...el.com, 
	lukasz.luba@....com, konradybcio@...nel.org, amitk@...nel.org, mani@...nel.org, 
	casey.connolly@...aro.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 3/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml
 bindings

On Wed, Dec 24, 2025 at 01:54:04PM +0530, Gaurav Kohli wrote:
> On 12/24/2025 1:00 AM, Dmitry Baryshkov wrote:
> > On Tue, Dec 23, 2025 at 06:02:22PM +0530, Gaurav Kohli wrote:
> > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
[..]
> > > +  vdd:
> > > +    $ref: "#/definitions/tmd"
> > > +    description:
> > > +      Modem processor temperature TMD
> > > +    properties:
> > > +      label:
> > > +        const: modem
> > Why it being called vdd?
> > 
> > Why do you define modem-specific node here, while the CDSP-specific is
> > defined under the if block?
> 
> 
> will remove modem in next post,  earlier we were developing for all
> subsystem.
> right now wanted to post for cdsp subsystem first, will fix in next post.
> 

No, upstream the binding and driver for all known endpoints (and test to
the best of your ability), then enable the ones you have on your
platform.

[..]
> > 
> > > +              label = "cdsp_sw";
> > > +              #cooling-cells = <2>;
> > > +            };
> > > +        };
> > > +    };
> > > +
> > > +    remoteproc-cdsp1 {
> > > +        cooling {
> > > +            compatible = "qcom,qmi-cooling-cdsp1";
> > > +
> > > +            cdsp_sw1: cdsp_sw {
> > > +              label = "cdsp_sw";
> > > +              #cooling-cells = <2>;
> > > +            };
> > > +        };
> > > +    };
> > What's the point of having the second CDSP block? Could you demonstrate
> > modem instead?
> 
> 
> Missed one cdsp1 block in this series, will add in next post. Leman's is
> using two cdsp subsystem for that we need cdsp1.
> 

It's just an example, make it as informative as possible.

Regards,
Bjorn

> 
> > > +...
> > > -- 
> > > 2.34.1
> > >