linux-kernel - Re: [PATCH net-next, 1/2] net: mana: Add support for coalesced RX packets on CQE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260102161147.1938b51d@kernel.org>
Date: Fri, 2 Jan 2026 16:11:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, "K. Y. Srinivasan"
 <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
 <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Long Li
 <longli@...rosoft.com>, Konstantin Taranov <kotaranov@...rosoft.com>, Simon
 Horman <horms@...nel.org>, Erni Sri Satya Vennela
 <ernis@...ux.microsoft.com>, Shradha Gupta
 <shradhagupta@...ux.microsoft.com>, Saurabh Sengar
 <ssengar@...ux.microsoft.com>, Aditya Garg
 <gargaditya@...ux.microsoft.com>, Dipayaan Roy
 <dipayanroy@...ux.microsoft.com>, Shiraz Saleem
 <shirazsaleem@...rosoft.com>, linux-kernel@...r.kernel.org,
 linux-rdma@...r.kernel.org, paulros@...rosoft.com
Subject: Re: [PATCH net-next, 1/2] net: mana: Add support for coalesced RX
 packets on CQE

On Fri,  2 Jan 2026 13:35:57 -0800 Haiyang Zhang wrote:
> +		NL_SET_ERR_MSG_FMT(extack, "Set rx-frames to %u failed:%d\n",
> +				   ec->rx_max_coalesced_frames, err);

No trailing new line in extack messages, please.
Also please do not duplicate the err value in the message itself,
it's already passed to user space. Well behaved user space will format
this as eg:

  Set rx-frames to 123 failed:-11: Invalid argument
-- 
pw-bot: cr