linux-kernel - Re: [PATCH v2 09/10] gpu: nova-core: simplify str_from_null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c153278-c334-4649-8f73-ec5676ad25b0@nvidia.com>
Date: Fri, 2 Jan 2026 19:37:31 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: Alistair Popple <apopple@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Edwin Peer <epeer@...dia.com>, Eliot Courtney <ecourtney@...dia.com>,
 nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
 Lyude Paul <lyude@...hat.com>
Subject: Re: [PATCH v2 09/10] gpu: nova-core: simplify
 str_from_null_terminated

On 12/15/25 8:27 PM, Alexandre Courbot wrote:
> The core library's `CStr` has a `from_bytes_until_nul` method that we
> can leverage to simplify this function.
> 
> Reviewed-by: Lyude Paul <lyude@...hat.com>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  drivers/gpu/nova-core/util.rs | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/nova-core/util.rs b/drivers/gpu/nova-core/util.rs
> index 8b2a4b99c55b..2cccbce78c14 100644
> --- a/drivers/gpu/nova-core/util.rs
> +++ b/drivers/gpu/nova-core/util.rs
> @@ -2,15 +2,10 @@
>  
>  /// Converts a null-terminated byte slice to a string, or `None` if the array does not
>  /// contains any null byte or contains invalid characters.
> -///
> -/// Contrary to [`core::ffi::CStr::from_bytes_with_nul`], the null byte can be anywhere in the
> -/// slice, and not only in the last position.
>  pub(crate) fn str_from_null_terminated(bytes: &[u8]) -> Option<&str> {
>      use core::ffi::CStr;
>  
> -    bytes
> -        .iter()
> -        .position(|&b| b == 0)
> -        .and_then(|null_pos| CStr::from_bytes_with_nul(&bytes[..=null_pos]).ok())
> +    CStr::from_bytes_until_nul(bytes)
> +        .ok()

I guess I should have reviewed this patch, before creating my version of this.
I went so far as to delete this file entirely, see if you prefer that, it's
otherwise the same core idea, but with more cleanup. [1]

[1] https://lore.kernel.org/20260103013438.247759-1-jhubbard@nvidia.com

>          .and_then(|cstr| cstr.to_str().ok())
>  }
> 

thanks,
-- 
John Hubbard