linux-kernel - Re: [PATCH] MIPS: Loongson64: dts: fix phy-related definition of LS7A GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ad2f826e1537884dfac40287cfee286b2ef63fb.camel@iscas.ac.cn>
Date: Sun, 04 Jan 2026 15:05:57 +0800
From: Icenowy Zheng <zhengxingda@...as.ac.cn>
To: Jiaxun Yang <jiaxun.yang@...goat.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Huacai Chen <chenhuacai@...nel.org>
Cc: devicetree@...r.kernel.org, "linux-mips@...r.kernel.org"
	 <linux-mips@...r.kernel.org>, linux-kernel@...r.kernel.org, 
	"stable@...r.kernel.org"
	 <stable@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Loongson64: dts: fix phy-related definition of
 LS7A GMAC

在 2026-01-02星期五的 22:36 +0000，Jiaxun Yang写道：
> 
> 
> On Fri, 2 Jan 2026, at 3:52 PM, Icenowy Zheng wrote:
> > Currently the LS7A GMAC device tree node lacks a proper phy-handle
> > property pointing to the PHY node.
> > 
> > In addition, the phy-mode property specifies "rgmii" without any
> > internal delay information, which means the board trace needs to
> > add 2ns
> > delay to the RGMII data lines; but that isn't known to happen on
> > any
> > Loongson board. The ACPI-based initialization codepath, which is
> > used on
> > LoongArch-based 3A5000 + 7A1000 hardwares, specifies "rgmii-id" phy
> > mode, which should be the one we are using.
> > 
> > Add the lacking phy-handle property and set proper phy-mode.
> > 
> > Tested on a LS3A4000_7A1000_NUC_BOARD_V2.1 board with YT8521S PHY.
> > 
> > Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>
> 
> Good catch! This with fine with realtek phy chips but YT8521S seems
> to be picky.

I think they might not work with Realtek PHYs now either, considering
delay override code for RTL8211E/F entered mainline Realtek PHY driver.
(Previously it just ignores the phy-mode internal delay information and
rely on what its strap pin defines)

> 
> Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> 
> Also maybe:
> 
> Cc: stable@...r.kernel.org
> 
> Given those boards rely on built-in DT.
> 
> Thanks
> 
> > ---
> >  arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi 
> > b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> > index ee71045883e7e..6dee85909f5a6 100644
> > --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> > +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> > @@ -199,7 +199,8 @@ gmac@3,0 {
> >                                              <13
> > IRQ_TYPE_LEVEL_HIGH>;
> >                                 interrupt-names = "macirq",
> > "eth_lpi";
> >                                 interrupt-parent = <&pic>;
> > -                               phy-mode = "rgmii";
> > +                               phy-mode = "rgmii-id";
> > +                               phy-handle = <&phy0>;
> >                                 mdio {
> >                                         #address-cells = <1>;
> >                                         #size-cells = <0>;
> > @@ -222,7 +223,8 @@ gmac@3,1 {
> >                                              <15
> > IRQ_TYPE_LEVEL_HIGH>;
> >                                 interrupt-names = "macirq",
> > "eth_lpi";
> >                                 interrupt-parent = <&pic>;
> > -                               phy-mode = "rgmii";
> > +                               phy-mode = "rgmii-id";
> > +                               phy-handle = <&phy1>;
> >                                 mdio {
> >                                         #address-cells = <1>;
> >                                         #size-cells = <0>;
> > -- 
> > 2.52.0
>