[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD++jLkcm8GfaKR73AjDmA5gBgp3Z+LX7khqLGgPGj2_s+oPRg@mail.gmail.com>
Date: Sun, 4 Jan 2026 13:53:15 +0100
From: Linus Walleij <linusw@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Eslam Khafagy <eslam.medhat1993@...il.com>, Arnd Bergmann <arnd@...db.de>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: pl111: fix build regression
On Tue, Dec 23, 2025 at 10:49 PM Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The drm_info() function requires the drm/drm_print.h header to be included
> first:
>
> In file included from drivers/gpu/drm/pl111/pl111_nomadik.c:7:
> drivers/gpu/drm/pl111/pl111_nomadik.h:11:32: error: 'struct drm_device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 11 | void pl111_nomadik_init(struct drm_device *dev);
> | ^~~~~~~~~~
> drivers/gpu/drm/pl111/pl111_nomadik.c: In function 'pl111_nomadik_init':
> drivers/gpu/drm/pl111/pl111_nomadik.c:34:9: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
> 34 | drm_info(dev, "set Nomadik PMU mux to CLCD mode\n");
> | ^~~~~~~~
> | pr_info
>
> Fixes: a1542b8ca6ed ("drm: pl111: replace dev_* print functions with drm_* variants")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Patch applied to drm-misc-next where the offending patch is.
Thanks!
Linus Walleij
Powered by blists - more mailing lists