linux-kernel - Re: [PATCH] rust: pci: add HeaderType enum and header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGAB666VQ764O-d0WoeOpu7uO+y+VV0TMisSfZ0n-7ENjO0BUQ@mail.gmail.com>
Date: Sun, 4 Jan 2026 23:23:48 +0900
From: 하승종 <engineer.jjhama@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: SeungJong Ha via B4 Relay <devnull+engineer.jjhama.gmail.com@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, 
	linux-pci@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: pci: add HeaderType enum and header_type() helper

2026년 1월 4일 (일) PM 10:40, Danilo Krummrich <dakr@...nel.org>님이 작성:
>
> On Sat Jan 3, 2026 at 4:39 PM CET, 하승종 wrote:
> > 2026년 1월 4일 (일) AM 12:17, Danilo Krummrich <dakr@...nel.org>님이 작성:
> >>
> >> On Sat Jan 3, 2026 at 3:38 PM CET, SeungJong Ha via B4 Relay wrote:
> >> > This is my first patch to the Linux kernel, specifically targeting the
> >> > Rust PCI subsystem.
> >>
> >> Thanks for your contribution!
> >>
> >> > This patch introduces the HeaderType enum to represent PCI configuration
> >> > space header types (Normal and Bridge) and implements the header_type()
> >> > method in the Device struct.
> >>
> >> We usually do not add dead code in the kernel. Do you work on a user for this
> >> API?
> >
> > Hi Danilo, Thanks for your feedback.
> >
> > Yes, I am currently developing a Rust-based driver for nvme and ixgbe devices,
> > which requires identifying the header type to check compatibility on
> > initialization.
> > I sent this patch first as it provides a foundational API for the PCI
> > abstraction.
>
> As Miguel also pointed out in his reply, I'd like to see a patch series with the
> driver as an RFC patch.
>
> If it is working, not too far from an "upstreamable" state and the subsystem
> maintainers of the driver's target subsystem are indicating willingness to
> eventually take the driver, I'm happy to go ahead and merge any dependencies.
>
> - Danilo

Hi Danilo, Muguel!

Thank you for the encouragement and the clear guidance.
Since my current driver implementation is still in a very early stage
and not yet
ready for public review, I will focus on maturing the codebase first.
I will come back with an RFC patch series that includes both the PCI
abstractions
and the driver once it reaches a more stable state.
Thank you again for your kind feedback and for guiding me through my first patch
submission.

- SeungJong Ha