linux-kernel - Re: [PATCH] selftests/nolibc: drop NOLIBC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVqYpdCpD8jAAA2X@1wt.eu>
Date: Sun, 4 Jan 2026 17:43:17 +0100
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: drop NOLIBC_SYSROOT=0 logic

On Sun, Jan 04, 2026 at 03:57:51PM +0100, Thomas Weißschuh wrote:
> This logic was added in commit 850fad7de827 ("selftests/nolibc: allow
> test -include /path/to/nolibc.h") to allow the testing of -include
> /path/to/nolibc.h. As it requires as special variable to activate, this
> code is nearly never used. Furthermore it complicates the logic a bit.
> 
> Since commit a6a054c8ad32 ("tools/nolibc: add target to check header
> usability") and commit 443c6467fcd6 ("selftests/nolibc: always run
> nolibc header check") the usability of -include /path/to/nolibc.h is
> always checked anyways, making NOLIBC_SYSROOT=0 pointless.
> 
> Drop the special logic.

I think that it was historically needed when we used to build by doing
-include nolibc.h but now that we've adopted most of the common headers,
we no longer build that way and instead use the sysroot, so yes, let's
drop this.

> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Acked-by: Willy Tarreau <w@....eu>

Willy