linux-kernel - Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXqX4QmbAf1vuUhy6b-KmUmYms+8GhJjq2gtiawVkwYvg@mail.gmail.com>
Date: Sun, 4 Jan 2026 13:13:12 -0800
From: Ian Rogers <irogers@...gle.com>
To: Joe Perches <joe@...ches.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Kuan-Wei Chiu <visitorckw@...il.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org, 
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an
 accidental patch separator

On Sun, Jan 4, 2026 at 10:54 AM Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2026-01-05 at 01:37 +0800, Kuan-Wei Chiu wrote:
> > +Cc Andrew Morton,
> []
>
> > That said, any Ack/Review or feedback from checkpatch.pl
> > maintainers/reviewers would still be helpful and appreciated.
>
>
> I think most of this is pointless and incorrect besides.
> A patch separator is specifically 3 dashes not a line that
> starts with 3 or more dashes.

Thanks Joe, do you have a reference for this? I was going off-of git's
behavior and I think the commit message covers that this patch is
fixing checkpatch.pl's behavior to match that of git's wrt lines
starting '---'. Or are you saying that git is broken and we should
patch git? In this case it would still be a useful lint test for
checkpatch.pl to warn about the '---' behavior for old versions of git
- at some future date when all gits have the patch then the
checkpatch.pl behavior can switch from '^---' to '^---$' again. In
summary, I think it is still the right thing for this patch to be
carried unless you have other concerns - could you be more specific on
what you mean by "most of this".

Thanks,
Ian

> See the original problem
> https://lore.kernel.org/lkml/20251203214706.112174-7-irogers@google.com/