[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <14098277-cbcf-4397-bf72-f9cf1613789b@grimberg.me>
Date: Sun, 4 Jan 2026 23:15:53 +0200
From: Sagi Grimberg <sagi@...mberg.me>
To: Mohamed Khalfella <mkhalfella@...estorage.com>
Cc: Chaitanya Kulkarni <kch@...dia.com>, Christoph Hellwig <hch@....de>,
Jens Axboe <axboe@...nel.dk>, Keith Busch <kbusch@...nel.org>,
Aaron Dailey <adailey@...estorage.com>,
Randy Jennings <randyj@...estorage.com>, John Meneghini
<jmeneghi@...hat.com>, Hannes Reinecke <hare@...e.de>,
linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 09/14] nvme: Implement cross-controller reset
completion
On 01/01/2026 1:51, Mohamed Khalfella wrote:
> On Sat 2025-12-27 12:24:17 +0200, Sagi Grimberg wrote:
>>> + log = kmalloc(sizeof(*log), GFP_KERNEL);
>>> + if (!log)
>>> + return;
>>> +
>>> + ret = nvme_get_log(ctrl, 0, NVME_LOG_CCR, 0x01,
>>> + 0x00, log, sizeof(*log), 0);
>>> + if (ret)
>>> + goto out;
>>> +
>>> + spin_lock_irqsave(&ctrl->lock, flags);
>>> + for (i = 0; i < le16_to_cpu(log->ne); i++) {
>>> + entry = &log->entries[i];
>>> + if (entry->ccrs == 0) /* skip in progress entries */
>>> + continue;
>> What does ccrs stand for?
> Cross-Controller Reset Status
>
> 0x00 -> In Progress
> 0x01 -> Success
> 0x02 -> Failed
> 0x03 - 0xff -> Reserved
Let's add it as a proper enumeration please.
Powered by blists - more mailing lists