linux-kernel - Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46d049cd-3307-4fbb-b33e-69ba05ded106@linaro.org>
Date: Mon, 5 Jan 2026 14:48:20 +0100
From: neil.armstrong@...aro.org
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 linux-amlogic@...ts.infradead.org, linux-pci@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 bhelgaas@...gle.com, robh@...nel.org, mani@...nel.org,
 kwilczynski@...nel.org, lpieralisi@...nel.org, yue.wang@...ogic.com
Subject: Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro

On 1/5/26 13:56, Martin Blumenstingl wrote:
> Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM
> L0s and L1 states") removed the waiting loop in meson_pcie_link_up()
> making #define WAIT_LINKUP_TIMEOUT now unused.
> 
> Drop the now unused variable to keep the driver code clean.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>   drivers/pci/controller/dwc/pci-meson.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index a1c389216362..0694084f612b 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -37,7 +37,6 @@
>   #define PCIE_CFG_STATUS17		0x44
>   #define PM_CURRENT_STATE(x)		(((x) >> 7) & 0x1)
>   
> -#define WAIT_LINKUP_TIMEOUT		4000
>   #define PORT_CLK_RATE			100000000UL
>   #define MAX_PAYLOAD_SIZE		256
>   #define MAX_READ_REQ_SIZE		256

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>