linux-kernel - Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXaj4vFy=5TLy27rcg8af4v5nJOT2_OyAU1XNO6=5VMXA@mail.gmail.com>
Date: Mon, 5 Jan 2026 07:39:34 -0800
From: Ian Rogers <irogers@...gle.com>
To: Joe Perches <joe@...ches.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Kuan-Wei Chiu <visitorckw@...il.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org, 
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an
 accidental patch separator

On Sun, Jan 4, 2026 at 2:22 PM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2026-01-04 at 13:13 -0800, Ian Rogers wrote:
> > On Sun, Jan 4, 2026 at 10:54 AM Joe Perches <joe@...ches.com> wrote:
> > >
> > > On Mon, 2026-01-05 at 01:37 +0800, Kuan-Wei Chiu wrote:
> > > > +Cc Andrew Morton,
> > > []
> > >
> > > > That said, any Ack/Review or feedback from checkpatch.pl
> > > > maintainers/reviewers would still be helpful and appreciated.
> > >
> > >
> > > I think most of this is pointless and incorrect besides.
> > > A patch separator is specifically 3 dashes not a line that
> > > starts with 3 or more dashes.
> >
> > Thanks Joe, do you have a reference for this?
> []
> > > See the original problem
> > > https://lore.kernel.org/lkml/20251203214706.112174-7-irogers@google.com/
>
> Did you look at this?

I was the author of it. The patch passed checkpatch.pl but then
created a commit with missing tags - ie it was broken. This patch is
fixing this issue so that checkpatch.pl will warn about the missing
tags prior to the patch being sent to LKML, which is kind of
checkpatch.pl's purpose. This is all detailed in the commit message.

Thanks,
Ian Rogers