linux-kernel - Re: [PATCH net] net: sfp: return the number of written bytes for smbus single byte access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <040995f9-5df2-4f5f-92c4-bedb8d1cd557@lunn.ch>
Date: Mon, 5 Jan 2026 16:40:52 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>,
	Jonas Jelonek <jelonek.jonas@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Simon Horman <horms@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>,
	Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH net] net: sfp: return the number of written bytes for
 smbus single byte access

On Mon, Jan 05, 2026 at 04:18:39PM +0100, Maxime Chevallier wrote:
> We expect the SFP write accessors to return the number of written bytes.
> We fail to do so for single-byte smbus accesses, which may cause errors
> when setting a module's high-power state and for some cotsworks modules.
> 
> Let's return the amount of written bytes, as expected.
> 
> Fixes: 7662abf4db94 ("net: phy: sfp: Add support for SMBus module access")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew