linux-kernel - Re: [PATCH v2 13/20] drm/tilcdc: Remove the useless module list support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260105164548.0f760c66@kmaincent-XPS-13-7390>
Date: Mon, 5 Jan 2026 16:45:48 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
Cc: "Jyri Sarha" <jyri.sarha@....fi>, "Tomi Valkeinen"
 <tomi.valkeinen@...asonboard.com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Russell King" <linux@...linux.org.uk>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Tony Lindgren" <tony@...mide.com>,
 "Andrzej Hajda" <andrzej.hajda@...el.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>, "Laurent
 Pinchart" <Laurent.pinchart@...asonboard.com>, "Jonas Karlman"
 <jonas@...boo.se>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Markus
 Schneider-Pargmann" <msp@...libre.com>, "Bajjuri Praneeth"
 <praneeth@...com>, "Louis Chauvet" <louis.chauvet@...tlin.com>, "Thomas
 Petazzoni" <thomas.petazzoni@...tlin.com>, "Miguel Gazquez"
 <miguel.gazquez@...tlin.com>, <dri-devel@...ts.freedesktop.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2 13/20] drm/tilcdc: Remove the useless module list
 support

On Wed, 17 Dec 2025 15:25:40 +0100
"Luca Ceresoli" <luca.ceresoli@...tlin.com> wrote:

> On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote:
> > The tilcdc driver previously supported a sub-module system where
> > external display drivers (panels, encoders) could register themselves
> > through tilcdc_module_init() and be automatically initialized through
> > a module list. This infrastructure became unused after the component
> > framework support and panel driver was removed.
> >
> > Signed-off-by: Kory Maincent (TI.com) <kory.maincent@...tlin.com>  
> 
> [...]
> 
> > @@ -562,24 +533,7 @@ static struct platform_driver tilcdc_platform_driver =
> > { .of_match_table = tilcdc_of_match,
> >  	},
> >  };
> > -
> > -static int __init tilcdc_drm_init(void)
> > -{
> > -	if (drm_firmware_drivers_only())
> > -		return -ENODEV;
> > -
> > -	DBG("init");
> > -	return platform_driver_register(&tilcdc_platform_driver);
> > -}
> > -
> > -static void __exit tilcdc_drm_fini(void)
> > -{
> > -	DBG("fini");
> > -	platform_driver_unregister(&tilcdc_platform_driver);
> > -}
> > -
> > -module_init(tilcdc_drm_init);
> > -module_exit(tilcdc_drm_fini);
> > +module_platform_driver(tilcdc_platform_driver);  
> 
> Is this hunk related to the removal of the module list? Looks like it
> should be a separate patch.

Indeed it is not directly related, but a following cleanup. I will put it in
another patch.

> 
> With that hunk removed (or kept if I'm wrong and it should stay):
> Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com