Message-ID: <5db81f5b-4f35-46e4-8fec-4298f1ac0c4e@redhat.com>
Date: Mon, 5 Jan 2026 17:23:42 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Rob Herring <robh@...nel.org>, Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Grzegorz Nitka <grzegorz.nitka@...el.com>, Jiri Pirko <jiri@...nulli.us>,
 Petr Oros <poros@...hat.com>, Michal Schmidt <mschmidt@...hat.com>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
 Richard Cochran <richardcochran@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, Simon Horman <horms@...nel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Willem de Bruijn <willemb@...gle.com>, Stefan Wahren <wahrenst@....net>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
 Horatiu Vultur <Horatiu.Vultur@...rochip.com>
Subject: Re: [PATCH RFC net-next 01/13] dt-bindings: net: ethernet-controller:
 Add DPLL pin properties

On 12/17/25 1:49 AM, Rob Herring wrote:
> On Thu, Dec 11, 2025 at 08:56:52PM +0100, Andrew Lunn wrote:
>> On Thu, Dec 11, 2025 at 08:47:44PM +0100, Ivan Vecera wrote:
>>> Ethernet controllers may be connected to DPLL (Digital Phase Locked Loop)
>>> pins for frequency synchronization purposes, such as in Synchronous
>>> Ethernet (SyncE) configurations.
>>>
>>> Add 'dpll-pins' and 'dpll-pin-names' properties to the generic
>>> ethernet-controller schema. This allows describing the physical
>>> connections between the Ethernet controller and the DPLL subsystem pins
>>> in the Device Tree, enabling drivers to request and manage these
>>> resources.
>>
>> Please include a .dts patch in the series which actually makes use of
>> these new properties.
> 
> Actually, first you need a device (i.e. a specific ethernet
> controller bindings) using this and defining the number of dpll-pins
> entries and the names.

The goal of this patch is to define properties that allow referencing
dpll pins from other devices. I included it in this series to allow
implementing helpers that use the property names defined in the schema.

This series implements the dpll pin consumer in the ice driver. This is
usually present on ACPI platforms, so the properties are stored in _DSD
ACPI nodes. Although I don't have a DT user right now, isn't it better
to define the schema now?

Thinking about this further, consumers could be either an Ethernet
controller (where the PHY is not exposed and is driven directly by the
NIC driver) or an Ethernet PHY.

For the latter case (Ethernet PHY), I have been preparing a similar
implementation for the Micrel phy driver (lan8814) on the Microchip EDS2
board (pcb8385). Unfortunately, the DTS is not upstreamed yet [1], so I
cannot include the necessary bindings here.

Since there can be multiple consumer types (Ethernet controller or PHY),
would it be better to define a dpll-pin-consumer.yaml schema instead
(similar to mux-consumer)?

Thanks for the advice,
Ivan

[1] 
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1031294&state=*

Powered by blists - more mailing lists