linux-kernel - Re: [PATCH v10 2/5] dt-bindings: backlight: gpio-backlight: allow multiple GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fhkit2bsfwzqpiytjdbg3oawbi3wbhpfcculbiyabe4vnslypr@77jlgmxukrhv>
Date: Mon, 5 Jan 2026 09:52:58 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Sudarshan Shetty <tessolveupstream@...il.com>
Cc: konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/5] dt-bindings: backlight: gpio-backlight: allow
 multiple GPIOs

On Tue, Dec 30, 2025 at 06:32:24PM +0530, Sudarshan Shetty wrote:
> Update the gpio-backlight binding to support configurations that require
> more than one GPIO for enabling/disabling the backlight.
> 

As with the driver change, please provide a better description of what
this means. How can there be multiple enable/disable GPIOs? What is
actually controlled by your two GPIOs? Why is 2 the new maximum?

Regards,
Bjorn

> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> ---
>  .../bindings/leds/backlight/gpio-backlight.yaml      | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> index 584030b6b0b9..1483ce4a3480 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> @@ -17,7 +17,8 @@ properties:
>  
>    gpios:
>      description: The gpio that is used for enabling/disabling the backlight.
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
>  
>    default-on:
>      description: enable the backlight at boot.
> @@ -38,4 +39,13 @@ examples:
>          default-on;
>      };
>  
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    backlight {
> +      compatible = "gpio-backlight";
> +      gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>,
> +              <&gpio3 5 GPIO_ACTIVE_HIGH>;
> +      default-on;
> +    };
> +
>  ...
> -- 
> 2.34.1
>