lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f44287d4-2f76-409d-b537-038896c5bc59@nvidia.com>
Date: Mon, 5 Jan 2026 16:06:22 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: "Sheetal ." <sheetal@...dia.com>, Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Thierry Reding <thierry.reding@...il.com>,
 Charles Keepax <ckeepax@...nsource.cirrus.com>, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache
 warning in tegra210_ahub

Hi Mark,

On 17/12/2025 13:40, Jon Hunter wrote:
> 
> On 17/12/2025 13:25, Sheetal . wrote:
>> From: sheetal <sheetal@...dia.com>
>>
>> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
>> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
>> that is observed for the Tegra210 AHUB driver. However, the change broke
>> various audio tests because an -EBUSY error is returned when accessing
>> registers from cache before they are read from hardware. Revert this
>> change for now, until a proper fix is available.
>>
>> Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache 
>> warning in tegra210_ahub")
>> Signed-off-by: sheetal <sheetal@...dia.com>
>> ---
>>   sound/soc/tegra/tegra210_ahub.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/ 
>> tegra210_ahub.c
>> index 261d9067d27b..e795907a3963 100644
>> --- a/sound/soc/tegra/tegra210_ahub.c
>> +++ b/sound/soc/tegra/tegra210_ahub.c
>> @@ -2077,7 +2077,7 @@ static const struct regmap_config 
>> tegra210_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA210_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra186_ahub_regmap_config = {
>> @@ -2085,7 +2085,7 @@ static const struct regmap_config 
>> tegra186_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA186_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra264_ahub_regmap_config = {
>> @@ -2094,7 +2094,7 @@ static const struct regmap_config 
>> tegra264_ahub_regmap_config = {
>>       .reg_stride        = 4,
>>       .writeable_reg        = tegra264_ahub_wr_reg,
>>       .max_register        = TEGRA264_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct tegra_ahub_soc_data soc_data_tegra210 = {
> 
> 
> Acked-by: Jon Hunter <jonathanh@...dia.com>

Now we are into the new year, I just wanted to send a reminder for this 
fix. We need to get this revert into v6.19.

Thanks!
Jon

-- 
nvpublic


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ