linux-kernel - Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fXDd7TV2MN_G9EQWdn1Cddg05prV7i=LVBin2HikND0rw@mail.gmail.com>
Date: Mon, 5 Jan 2026 09:13:49 -0800
From: Ian Rogers <irogers@...gle.com>
To: Joe Perches <joe@...ches.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Kuan-Wei Chiu <visitorckw@...il.com>, 
	Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org, 
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an
 accidental patch separator

On Mon, Jan 5, 2026 at 8:46 AM Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2026-01-05 at 07:39 -0800, Ian Rogers wrote:
> > I was the author of it. The patch passed checkpatch.pl but then
> > created a commit with missing tags - ie it was broken. This patch is
> > fixing this issue so that checkpatch.pl will warn about the missing
> > tags prior to the patch being sent to LKML, which is kind of
> > checkpatch.pl's purpose. This is all detailed in the commit message.
>
> Whatever was the tool that applied the patch should be fixed instead.

The tool was git. As I mentioned, we can patch git but old versions
will still have the '^---' rather than '^---$' behavior and so these
checkpatch.pl tests remain useful.

Thanks,
Ian