linux-kernel - Re: [PATCH] PCI: meson: Remove meson_pcie_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2veit3krpnauq67smexshnknbahup4yuckjgd6bxqisfqswkqe@dbhcgpiaajga>
Date: Mon, 5 Jan 2026 22:45:56 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc: Yue Wang <yue.wang@...ogic.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Linnaea Lavia <linnaea-von-lavia@...e.com>,
        FUKAUMI Naoki <naoki@...xa.com>,
        Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        stable@...r.kernel.org, Ricardo Pardini <ricardo@...dini.net>
Subject: Re: [PATCH] PCI: meson: Remove meson_pcie_link_up() timeout,
 message, speed check

On Mon, Jan 05, 2026 at 05:49:00PM +0100, Martin Blumenstingl wrote:
> Hi Mani,
> 
> On Thu, Dec 18, 2025 at 7:06 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@....qualcomm.com> wrote:
> >
> >
> > On Mon, 03 Nov 2025 16:19:26 -0600, Bjorn Helgaas wrote:
> > > Previously meson_pcie_link_up() only returned true if the link was in the
> > > L0 state.  This was incorrect because hardware autonomously manages
> > > transitions between L0, L0s, and L1 while both components on the link stay
> > > in D0.  Those states should all be treated as "link is active".
> > >
> > > Returning false when the device was in L0s or L1 broke config accesses
> > > because dw_pcie_other_conf_map_bus() fails if the link is down, which
> > > caused errors like this:
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] PCI: meson: Remove meson_pcie_link_up() timeout, message, speed check
> >       commit: 11647fc772e977c981259a63c4a2b7e2c312ea22
> My understanding is that this is queued for -next.
> Ricardo (Cc'ed) reported that this patch fixes PCI link up on his Odroid-HC4.
> Is there a chance to get this patch into -fixes, so it can be pulled
> by Linus for one of the next -rc?
> 

Hmm, I looked at the Fixes tag and mistakenly assumed that the issue existed
from the beginning.

Bjorn, could you please include this patch in the next fixes PR?

- Mani

-- 
மணிவண்ணன் சதாசிவம்