linux-kernel - Re: [PATCH rdma-next 3/6] RDMA/mlx5: Fix ucaps init error flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nMHnzC-ZHH6ZqiE-aiuo-+61K1yB6xT1Vc6rovuP2muLg@mail.gmail.com>
Date: Mon, 5 Jan 2026 09:07:36 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Leon Romanovsky <leon@...nel.org>
Cc: Jason Gunthorpe <jgg@...pe.ca>, Yishai Hadas <yishaih@...dia.com>, 
	Chiara Meiohas <cmeiohas@...dia.com>, Michal Kalderon <mkalderon@...vell.com>, 
	Selvin Xavier <selvin.xavier@...adcom.com>, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Maher Sanalla <msanalla@...dia.com>
Subject: Re: [PATCH rdma-next 3/6] RDMA/mlx5: Fix ucaps init error flow

On Sun, Jan 4, 2026 at 7:22 PM Leon Romanovsky <leon@...nel.org> wrote:
>
> From: Maher Sanalla <msanalla@...dia.com>
>
> In mlx5_ib_stage_caps_init(), if mlx5_ib_init_ucaps() fails after
> mlx5_ib_init_var_table() succeeds, the VAR bitmap is leaked since
> the function returns without cleanup.
>
> Thus, cleanup the var table bitmap in case of error of initializing
> ucaps before exiting, preventing the leak above.
>
> Fixes: cf7174e8982f ("RDMA/mlx5: Create UCAP char devices for supported device capabilities")
> Signed-off-by: Maher Sanalla <msanalla@...dia.com>
> Reviewed-by: Yishai Hadas <yishaih@...dia.com>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>


-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5509 bytes)