linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8mp-skov: add pinctrl-name 'reset' to fix CHECK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVvzKQKjaZUVs5oi@lizhi-Precision-Tower-5810>
Date: Mon, 5 Jan 2026 12:21:45 -0500
From: Frank Li <Frank.li@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp-skov: add pinctrl-name 'reset' to
 fix CHECK_DTB warning

On Mon, Jan 05, 2026 at 12:14:48PM +0100, Marco Felsch wrote:
> Hi Frank,
>
> On 25-12-29, Frank Li wrote:
> > Add pinctrl-name 'reset' to fix below CHECK_DTB warnings:
> >   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> >
> > The commit (e469b87e0fb0d dt-bindings: net: dsa: microchip: Add strap
> > description to set SPI mode" force use two pinctrl-name 'default' and
> > 'reset'. switch@5f doesn't use SPI, so it is safe to use the same pinctrl
> > setting for both.
>
> please see:
> - https://lore.kernel.org/all/20251112084717.ea7fchu7jcz6dzsi@pengutronix.de/
>
> I stumbled over the same warning, but came to the conclusion, that the
> dt-bindings should be fixed instead of workaround broken bindings within
> the dtb.

I have not seen "the conclusion" at above thread. I think patch 'reset' may
be reasonable for SPI pin, which used for stub at reset. And there are not
good method to distinguish under SPI or I2C.

Frank

>
> Regards,
>   Marco
>
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> > index 020f20c8ce667..7d2fc5fdd3bd1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> > @@ -373,8 +373,8 @@ &i2c4 {
> >
> >  	switch: switch@5f {
> >  		compatible = "microchip,ksz9893";
> > -		pinctrl-names = "default";
> > -		pinctrl-0 = <&pinctrl_switch>;
> > +		pinctrl-names = "default", "reset";
> > +		pinctrl-0 = <&pinctrl_switch>, <&pinctrl_switch>;
> >  		reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
> >  		reg = <0x5f>;
> >
> > --
> > 2.34.1
> >
> >
> >
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |