linux-kernel - Re: [PATCH] x86/cpu: drop unused Kconfig symbol X86_P6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1005ffa1-aa1d-45ac-9c57-236593d40f36@intel.com>
Date: Mon, 5 Jan 2026 13:02:58 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Subject: Re: [PATCH] x86/cpu: drop unused Kconfig symbol X86_P6_NOP

On 12/28/25 15:27, Randy Dunlap wrote:
> -# Bug fix for binutils: this option is required in order to keep
> -# binutils from generating NOPL instructions against our will.
> -ifneq ($(CONFIG_X86_P6_NOP),y)
> -cflags-y			+= $(call cc-option,-Wa$(comma)-mtune=generic32,)
> -endif

Isn't this adding the cflags when CONFIG_X86_P6_NOP is _not_ =y? Isn't
this the case now that X86_P6_NOP has been zapped from the tree? Doesn't
that make the straightforward "fix" to just remove the reference to
CONFIG_X86_P6_NOP, but leave the cflags-y like this?

-ifneq ($(CONFIG_X86_P6_NOP),y)
 cflags-y	+= $(call cc-option,-Wa$(comma)-mtune=generic32,)
-endif

It's either that or I'm reading the Makefile logic backwards (wouldn't
be the first time :).