linux-kernel - Re: [PATCH] atm: Fix dma_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbb300d1-ccdc-4a4b-8110-1e2d27367620@amd.com>
Date: Mon, 5 Jan 2026 13:55:10 -0800
From: "Creeley, Brett" <bcreeley@....com>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: stable@...r.kernel.org, Chas Williams <3chas3@...il.com>,
 chas williams - CONTRACTOR <chas@....nrl.navy.mil>,
 "David S. Miller" <davem@...emloft.net>,
 linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: Fix dma_free_coherent() size



On 1/5/2026 1:19 PM, Thomas Fourier wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The size of the buffer is not the same when alloc'd with
> dma_alloc_coherent() in he_init_tpdrq() and freed.
>
> Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
>   drivers/atm/he.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atm/he.c b/drivers/atm/he.c
> index ad91cc6a34fc..92a041d5387b 100644
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -1587,7 +1587,8 @@ he_stop(struct he_dev *he_dev)
>                                    he_dev->tbrq_base, he_dev->tbrq_phys);
>
>          if (he_dev->tpdrq_base)
> -               dma_free_coherent(&he_dev->pci_dev->dev, CONFIG_TBRQ_SIZE * sizeof(struct he_tbrq),
> +               dma_free_coherent(&he_dev->pci_dev->dev,
> +                                 CONFIG_TPDRQ_SIZE * sizeof(struct he_tpdrq),

Sizes seem to align now. LGTM.

Reviewed-by: Brett Creeley <brett.creeley@....com>
>                                    he_dev->tpdrq_base, he_dev->tpdrq_phys);
>
>          dma_pool_destroy(he_dev->tpd_pool);
> --
> 2.43.0
>
>