linux-kernel - Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <745af80f-58df-46a2-8316-f52b0ea6d7ec@infradead.org>
Date: Mon, 5 Jan 2026 15:54:21 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: linux-kernel@...r.kernel.org, Vaibhav Hiremath
 <hvaibhav.linux@...il.com>, Johan Hovold <johan@...nel.org>,
 Alex Elder <elder@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol

Hi Dan,

On 1/5/26 2:16 AM, Dan Carpenter wrote:
> On Mon, Jan 05, 2026 at 01:09:17PM +0300, Dan Carpenter wrote:
>> On Tue, Dec 30, 2025 at 10:23:40AM -0800, Randy Dunlap wrote:
>>>
>>>
>>> On 12/29/25 10:27 PM, Randy Dunlap wrote:
>>>> --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig
>>>> +++ linux-next-20251219/drivers/staging/greybus/Kconfig
>>>> @@ -206,7 +206,6 @@ endif	# GREYBUS_BRIDGED_PHY
>>>>  
>>>>  config GREYBUS_ARCHE
>>>>  	tristate "Greybus Arche Platform driver"
>>>> -	depends on USB_HSIC_USB3613 || COMPILE_TEST
>>>>  	help
>>>>  	  Select this option if you have an Arche device.
>>>
>>> Perhaps I should have left COMPILE_TEST here, like:
>>>
>>> 	depends on COMPILE_TEST
>>>
>>> ?
>>
>> If we're going to do that, we should just delete it.  It's been
>> impossible to build for eight years.
>>

I saw that. I just wanted some feedback on it first.
I'll send v2.

> 
> I did a `git grep 'depends on COMPILE_TEST'` for other drivers which
> are never used and only found this one which was disabled in 2018.

Looks like it should go away also. Thanks.

> regards,
> dan carpenter
> 
> commit da2827a298f8a2159f31466759cbba2dd4f1b65f
> Author: Arnd Bergmann <arnd@...db.de>
> Date:   Fri Mar 9 22:45:26 2018 +0100
> 
>     usb: isp1362: remove blackfin arch glue
> 
>     The blackfin architecture is getting removed, and this is the last
>     remaining architecture specific setting, so the various hacks
>     can be removed now.
> 
>     From all I can tell, there are no remaining in-tree users of the
>     driver, but it could be used by out-of-tree platform ports.
>     I've marked the driver as 'depends on COMPILE_TEST', short of
>     removing it outright.
> 
>     It was originally written for some ARM PXA machines using the same
>     chip, but that platform never really worked and the code has been
>     removed a long time ago.
> 
>     Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>     Acked-by: Aaron Wu <aaron.wu@...log.com>
>     Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 4fcfb3084b36..b85822f0c874 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -360,6 +360,7 @@ config USB_ISP116X_HCD
>  config USB_ISP1362_HCD
>         tristate "ISP1362 HCD support"
>         depends on HAS_IOMEM
> +       depends on COMPILE_TEST # nothing uses this
>         ---help---
>           Supports the Philips ISP1362 chip as a host controller
> 

-- 
~Randy