linux-kernel - Re: [PATCH v4] mm/vmscan: fix demotion targets checks in reclaim/demotion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVtH4tXHgx0a3udf@google.com>
Date: Mon, 5 Jan 2026 05:10:58 +0000
From: Bing Jiao <bingjiao@...gle.com>
To: Chen Ridong <chenridong@...weicloud.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, gourry@...rry.net, longman@...hat.com,
	hannes@...xchg.org, mhocko@...nel.org, roman.gushchin@...ux.dev,
	shakeel.butt@...ux.dev, muchun.song@...ux.dev, tj@...nel.org,
	mkoutny@...e.com, david@...nel.org, zhengqi.arch@...edance.com,
	lorenzo.stoakes@...cle.com, axelrasmussen@...gle.com,
	yuanchu@...gle.com, weixugc@...gle.com, cgroups@...r.kernel.org
Subject: Re: [PATCH v4] mm/vmscan: fix demotion targets checks in
 reclaim/demotion

On Mon, Jan 05, 2026 at 10:48:09AM +0800, Chen Ridong wrote:
> >  	cs = container_of(css, struct cpuset, css);
> > -	allowed = node_isset(nid, cs->effective_mems);
> > +	nodes_and(*mask, *mask, cs->effective_mems);
>
> Why do we need the and operation? Can't we just copy cs->effective_mems to mask directly?
>
> Per Longman's suggestion, name it cpuset_nodes_allowed and handle the filtering in
> mem_cgroup_node_filter_allowed. Please keep the allowed nodes retrieval logic common.
>
> Best regards,
> Ridong

Thank you for the explanation and suggestions.

Patch v5 has been sent with the corresponding updates.

Best,
Bing